Skip to content

Add visual muzzle flash for invisible soldiers#550

Merged
majcosta merged 1 commit into
1dot13:masterfrom
steph-pg:fix_no_muzzle_flashes
Oct 19, 2025
Merged

Add visual muzzle flash for invisible soldiers#550
majcosta merged 1 commit into
1dot13:masterfrom
steph-pg:fix_no_muzzle_flashes

Conversation

@steph-pg
Copy link
Copy Markdown
Contributor

For some reason we don't draw muzzle flashes for currently unseen soldiers which makes them absolutely useless.

@kitty624
Copy link
Copy Markdown
Contributor

kitty624 commented Oct 19, 2025

eh, if we can't see the soldier, how are we gonna see any of its actions?
like, what's invisble for the game?
out of distance? may show the flash.
behind a house or other obstacle, don't show flash.
in our mercs back? don't show
etc

@steph-pg
Copy link
Copy Markdown
Contributor Author

How, then his flash can give up his location? With current code the guy can shoot from darkness using NVG, or they can shoot from darkness at someone standing in light and his weapon will produce no flash. You can stop using flash suppressor completely. I see the problem that it will enable all the flashes but since they are shooting at someone that's better than what we have now.

@kitty624 kitty624 requested a review from majcosta October 19, 2025 09:55
@majcosta
Copy link
Copy Markdown
Contributor

I don't understand what this does. I tested this at night it behaves the same with or without, as far as enemies shooting at you from out of line of sight is concerned.

@steph-pg
Copy link
Copy Markdown
Contributor Author

Jagged.Alliance.2.2025-10-19.13-14-07.mp4

@steph-pg
Copy link
Copy Markdown
Contributor Author

Jagged.Alliance.2.2025-10-19.13-14-58.mp4

@majcosta
Copy link
Copy Markdown
Contributor

Ah, I see. 👍

@majcosta majcosta merged commit 9ce1492 into 1dot13:master Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants