Skip to content

Load old ObjectData correctly#553

Merged
Asdow merged 2 commits into
masterfrom
action-item-load-fix
Nov 11, 2025
Merged

Load old ObjectData correctly#553
Asdow merged 2 commits into
masterfrom
action-item-load-fix

Conversation

@Asdow
Copy link
Copy Markdown
Contributor

@Asdow Asdow commented Nov 10, 2025

ITS changed ObjectDataStructs::OBJECT_BOMBS_AND_OTHER::ubBombOwner data size from 1 byte to 2 bytes, and it was not taken into account when loading ObjectData

ITS changed ObjectDataStructs::OBJECT_BOMBS_AND_OTHER::ubBombOwner data size from 1 byte to 2 bytes, and it was not taken into account when loading ObjectData
@Asdow Asdow requested a review from majcosta November 10, 2025 19:02
Copy link
Copy Markdown
Contributor

@majcosta majcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Tactical/Item Types.h
Comment thread Tactical/Item Types.h
UINT8 ubImprintID; // ID of merc that item is imprinted on

// Flugente: due do inconsistencies with WF maps, where data from a map is laoded differently, I had to add this marker.
// Flugente: due do inconsistencies with WF maps, where data from a map is loaded differently, I had to add this marker.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do this in its own PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Comment thread Tactical/Item Types.h
UINT8 fUsed; // flags for whether the item is used or not
};


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do this in its on PR

Comment thread Ja2/SaveLoadGame.cpp Outdated
Comment thread Ja2/SaveLoadGame.cpp Outdated
Comment thread Tactical/Item Types.cpp Outdated
Comment thread Tactical/Item Types.h Outdated
Comment thread Tactical/Item Types.h Outdated
Comment thread Tactical/Item Types.cpp Outdated
Comment thread Ja2/SaveLoadGame.cpp Outdated
@Asdow Asdow merged commit 2641050 into master Nov 11, 2025
12 checks passed
@Asdow Asdow deleted the action-item-load-fix branch November 11, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants