Skip to content

Remove magic numbers #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Asdow merged 1 commit into from
Jan 4, 2026
Merged

Remove magic numbers #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Laptop/email.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,11 @@ UINT32 guiEmailWarning;
#define SUBJECT_LINE_Y VIEWER_Y+42
#define SUBJECT_LINE_WIDTH 278-47


//max number of lines can be shown in an opened email messagebox
#define MAX_EMAIL_LINES 20
// maximum size of a email message page, so not to overrun the bottom of the screen
#define MAX_EMAIL_MESSAGE_PAGE_SIZE ( GetFontHeight( MESSAGE_FONT ) + MESSAGE_GAP ) * 20
#define MAX_EMAIL_MESSAGE_PAGE_SIZE ( GetFontHeight( MESSAGE_FONT ) + MESSAGE_GAP ) * MAX_EMAIL_LINES

enum{
PREVIOUS_BUTTON=0,
NEXT_BUTTON,
Expand Down Expand Up @@ -5475,7 +5477,7 @@ UINT32 cnt;
void PreProcessEmail( EmailPtr pMail )
{
RecordPtr pTempRecord, pCurrentRecord, pLastRecord , pTempList;
CHAR16 pString[ 512 ];
CHAR16 pString[MAIL_STRING_SIZE];
INT32 iCounter = 0, iHeight = 0, iOffSet = 0;
BOOLEAN fGoingOffCurrentPage = FALSE;
INT32 iYPositionOnPage = 0;
Expand Down
3 changes: 1 addition & 2 deletions Laptop/email.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
#include "soldier profile type.h"

// defines
#define MAX_EMAIL_LINES 10 //max number of lines can be shown in a message
#define MAX_MESSAGES_PAGE 18 // max number of messages per page
#define MAX_MESSAGES_PAGE 18 // max number of emails per page in inbox

//---ja25 ub
#ifdef JA2UB
Expand Down