fix(compose): "Save Draft" publishes instead of drafting (#98)#99
Merged
Conversation
Build FormData before disabling buttons — disabled fields are skipped from entry-list construction, including the submitter. Server-side: drafts redirect to /admin/drafts instead of the canonical URL (404s).
Collaborator
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
compose.jsdisabled the submitter button beforenew FormData(form, submitter). Per HTML spec, disabled form fields are skipped during entry-list construction — including the submitter — sodraft=onnever reached the wire. Reorder: build FormData before disabling. Server: drafts redirected to canonical URL (404s for drafts); now redirect to/admin/draftsfrom bothHandleSubmitandHandleEdit. Tests cover both paths. Pre-existing in v3.17.0; surfaced during the #97 readability pass. Closes #98.