feat(oauth): enhance OAuth flow with reconnect and capability discovery #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and add tests - Enhanced `serveCommand` to derive the session storage path based on provided options, prioritizing explicit paths over defaults. - Added unit tests for `serveCommand` to verify correct session storage path behavior when using `config-dir` and `session-storage-path`. - Updated `TransportFactory` to ensure client session paths align with server session paths for consistent isolation. - Mocked dependencies in tests to prevent actual server initialization and ensure reliable test outcomes.
…teTracker and McpLoadingManager - Added `LoadingStateEvent` enum to define event types for `LoadingStateTracker`, improving type safety and readability. - Updated `LoadingStateEvents` interface to use the new enum for event names. - Introduced `McpLoadingEvent` enum for `McpLoadingManager` to standardize event names and enhance maintainability. - Refactored event emission in both classes to utilize the new enums, ensuring consistent event handling across the loading system.
- Updated OAuth routes to check for compatible transport types (HTTP or SSE) before completing the OAuth flow. - Implemented reconnection logic after OAuth completion to establish an authenticated connection. - Added capability discovery and instruction caching after successful reconnection. - Enhanced unit tests to verify the new behavior and ensure proper handling of OAuth flow.
- Updated OAuth routes to validate transport types, ensuring only StreamableHTTPClientTransport and SSEClientTransport are accepted for OAuth flows. - Removed the previous type guard for transport and replaced it with instanceof checks for better clarity and maintainability. - Enhanced unit tests to mock transport instances correctly, ensuring they pass the instanceof checks for proper OAuth handling.
…tion - Add `completeOAuthAndReconnect` method to `ClientManager` to handle OAuth completion and client reconnection for HTTP and SSE transports - Support both `StreamableHTTPClientTransport` and `SSEClientTransport` in OAuth flow - Recreate transport and client instances after OAuth completion since HTTP transports cannot be restarted - Update client status and capabilities after successful reconnection - Refactor OAuth callback route to delegate reconnection logic to `ClientManager` - Add comprehensive tests for OAuth reconnection scenarios including success, unsupported transport, and error handling cases - Import required transport classes and types in client manager and OAuth route files
xizhibei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
completeOAuthAndReconnectmethod in ClientManager to properly handle OAuth callback completion with transport recreationKey Changes
OAuth Callback Handling
completeOAuthAndReconnectmethod in ClientManager that:Session Storage Improvements
Event System Type Safety
LoadingStateEventenum in LoadingStateTrackerMcpLoadingEventenum in McpLoadingManagerTest Coverage
Test Plan
Breaking Changes
None - all changes are backward compatible and additive.