feat(eslint-config): migrate project to projectService for TypeScript#369
Conversation
🦋 Changeset detectedLatest commit: c883d0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate limit exceeded@JounQin has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 24 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the TypeScript configuration setting from using the "project" property to a new "projectService" flag. Key changes include:
- Spreading parserOptions from the tsBase configuration into the Vue ESLint configuration.
- Replacing the "project" property with "projectService: true" in the tsBase configuration.
- Updating the changeset documentation to reflect the migration.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/eslint-config/vue.js | Added spread of parserOptions from tsBase to integrate settings |
| packages/eslint-config/ts-base.js | Replaced project with projectService flag for TypeScript config |
| .changeset/forty-colts-laugh.md | Documented the feature migration in the changeset |
Comments suppressed due to low confidence (1)
packages/eslint-config/ts-base.js:28
- Ensure that the downstream consumers of tsBase configuration correctly handle the new 'projectService' flag in lieu of the former 'project' property.
projectService: true,
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 39 39
Lines 257 257
Branches 120 120
======================================
Misses 257 257 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to c883d0f in 41 seconds. Click for details.
- Reviewed
36lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .changeset/forty-colts-laugh.md:1
- Draft comment:
Changeset file is formatted correctly. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. packages/eslint-config/ts-base.js:28
- Draft comment:
Migrated to projectService: true. Consider removing the unused import 'project' from _util.js if no longer needed. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. packages/eslint-config/vue.js:42
- Draft comment:
Spreading tsBase[0].languageOptions?.parserOptions propagates the new projectService config. Confirm the merge order is as intended. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_ur6sMYFrFQDkbjE4
You can customize 
@1stg/app-config
@1stg/babel-preset
@1stg/commitlint-config
@1stg/browserslist-config
@1stg/common-config
@1stg/config
@1stg/eslint-config
@1stg/markuplint-config
@1stg/nano-staged
@1stg/postcss-config
@1stg/prettier-config
@1stg/remark-preset
@1stg/simple-git-hooks
@1stg/stylelint-config
@1stg/tsconfig
commit: |
close #366
Important
Migrate TypeScript ESLint configuration from
projecttoprojectServiceints-base.jsandvue.js.projecttoprojectServicein TypeScript ESLint configuration.tsBaseints-base.jsandvueinvue.js.parserOptionsto useprojectService: trueints-base.js.parserOptionsinvue.jsto includetsBasesettings.This description was created by
for c883d0f. You can customize this summary. It will automatically update as commits are pushed.