Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough강의 생성·수정 기능(스키마, API, 훅, 폼, 페이지)과 경로 상수화(ROUTES)가 추가되었습니다. API 오류 처리 유틸(handleApiError), ConfirmModal, 입력 컴포넌트 개선(forwardRef, 에러/기본값), 삭제 흐름의 ConfirmModal 전환, ESLint 경계 설정 및 패키지 변경이 포함됩니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User as 사용자
participant Form as CourseForm<br/>(UI)
participant Hook as useCreateCourse<br/>(훅)
participant API as courseApi<br/>(HTTP)
participant Cache as React Query<br/>캐시
participant Router as 라우터
User->>Form: 강의 정보 입력 및 확인 클릭
Form->>Form: courseFormSchema로 검증
Form->>Hook: submit(formValues)
Hook->>Hook: SEMESTER_CODE_MAP으로 매핑
Hook->>API: POST /courses (createCourse)
API-->>Hook: CreateCourseResponse
Hook->>Cache: courseQueries.getAllCourses 무효화
Hook->>Router: navigate(ROUTES.ADMIN.ROOT)
Router-->>User: 강의 관리 페이지로 이동
sequenceDiagram
participant User as 사용자
participant Page as CourseEditPage<br/>(페이지)
participant Cache as React Query<br/>캐시
participant Form as CourseForm<br/>(UI)
participant Hook as useEditCourse<br/>(훅)
participant API as courseApi<br/>(HTTP)
participant Router as 라우터
Page->>Cache: useQuery로 강의 조회 (getCourseDetails)
Cache-->>Page: CourseOverview 데이터
Page->>Form: defaultValues 전달
User->>Form: 수정 및 확인 클릭
Form->>Hook: submit(formValues)
Hook->>API: PUT /courses/{id} (updateCourse)
API-->>Hook: CreateCourseResponse
Hook->>Cache: courseQueries.getAllCourses 무효화
Hook->>Router: navigate(ROUTES.ADMIN.ROOT)
Router-->>User: 강의 관리 페이지로 이동
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested labels
Suggested reviewers
짧은 칭찬: 훅·폼·라우트 분리는 깔끔해요 — 유지보수하기 좋습니다. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/shared/ui/LabeledInput.tsx (1)
8-35:⚠️ Potential issue | 🔴 Critical
required/오류 상태를 시각적으로만 표시하지 말고 input에도 전달해 주세요.지금은 별표와 빨간 테두리만 바뀌고, 실제 input에는
required,aria-invalid,aria-describedby가 없어 브라우저 기본 검증과 스크린리더 안내가 빠집니다.이 컴포넌트는
CourseForm,UnitForm,AssignmentCreatePage등 4곳 이상에서 사용 중이므로, 접근성 회귀가 여러 폼에 즉시 영향을 줍니다.♿ 제안 패치
const LabeledInput = ({ label, className, showLabel = true, errorMessage, required = true, ...rest }: LabeledInputProps) => { + const errorId = rest.id ? `${rest.id}-error` : undefined; + return ( <label className='flex flex-col gap-3'> @@ <input + required={required} + aria-invalid={Boolean(errorMessage)} + aria-describedby={errorMessage ? errorId : undefined} className={`h-11 rounded-[9px] border px-[14px] outline-none focus:border-primary ${ errorMessage ? 'border-badge-red' : 'border-purple-stroke' } ${className ?? ''}`} {...rest} /> {errorMessage && ( - <span className='text-sm text-badge-red'>{errorMessage}</span> + <span id={errorId} className='text-sm text-badge-red'> + {errorMessage} + </span> )}참고: MDN
required/aria-invalid/ 폼 접근성
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/required
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-invalid
https://developer.mozilla.org/en-US/docs/Learn/Accessibility/WAI-ARIA_basics/🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/shared/ui/LabeledInput.tsx` around lines 8 - 35, The LabeledInput component currently only shows visual required/error cues; update it to pass accessibility attributes into the <input> by forwarding the required prop to the input, setting aria-invalid to true when errorMessage is present, and adding aria-describedby that points to the error message element. To implement this, ensure the input has an id (use the incoming rest.id if provided or React's useId() inside LabeledInput to generate one), render the error <span> with a matching unique id (e.g., `${id}-error`), and set aria-describedby to that id only when errorMessage exists; keep existing visual changes intact and reference the LabeledInput props required and errorMessage and the input/error span identifiers when making the change.
🧹 Nitpick comments (6)
src/shared/lib/handleApiError.ts (2)
26-29:fallbackMessage사용 시 원본 에러 메시지 손실 가능성
fallbackMessage가 제공되면getApiErrorMessage결과가 무시됩니다. 의도된 동작이라면 괜찮지만, 에러 컨텍스트를 유지하면서 커스텀 메시지를 보여주고 싶다면 로깅에 원본 메시지를 포함하는 것을 고려해보세요.현재 코드베이스 전반에서
alert()을 사용하고 있어 일관성은 유지되지만, 추후 Toast/Modal 시스템으로 전환할 때 이 함수가 중앙 포인트가 될 수 있습니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/shared/lib/handleApiError.ts` around lines 26 - 29, The current handleApiError function ignores the original error message when fallbackMessage is provided; update handleApiError to always capture and log the original API error message from getApiErrorMessage(error) while still showing the fallbackMessage to the user (use console.error to emit both the fallbackMessage and the original message/context from getApiErrorMessage(error) along with the raw error), keep alert(message) behavior but ensure logging retains full error context so callers using handleApiError (and functions like getApiErrorMessage) can debug later.
6-21: HTTP 상태 코드 매핑 - 429 (Too Many Requests) 추가 고려현재 400, 401, 403, 404, 409, 5xx를 처리하고 있습니다. Rate limiting 대응을 위해 429 상태도 추가하면 좋겠습니다.
♻️ 429 상태 추가 제안
if (status === 409) return '이미 존재하는 정보입니다.'; + if (status === 429) return '요청이 너무 많습니다. 잠시 후 다시 시도해주세요.'; if (status && status >= 500) return '서버 오류가 발생했습니다. 잠시 후 다시 시도해주세요.';🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/shared/lib/handleApiError.ts` around lines 6 - 21, Add handling for HTTP 429 inside getApiErrorMessage: when axios.isAxiosError(error) detects a response with status === 429 return a clear rate-limit message (e.g., '요청이 너무 많습니다. 잠시 후 다시 시도해주세요.') and place this check alongside the other status checks (400, 401, 403, 404, 409, 5xx) so 429 is matched before the generic fallbacks; keep the rest of the function behavior unchanged.src/features/course/delete-course/model/useDeleteCourse.ts (1)
2-2: 변수명 섀도잉 주의:deleteCourse중복 사용Line 2에서
deleteCourseAPI 함수를 import하고, Line 24에서mutate를deleteCourse로 재명명하여 반환합니다. 이름이 동일해 혼란을 줄 수 있습니다.♻️ 명확한 네이밍 제안
- import {deleteCourse, courseQueries} from '@/entities/course'; + import {deleteCourse as deleteCourseApi, courseQueries} from '@/entities/course'; const {mutate, isPending} = useMutation({ - mutationFn: () => deleteCourse(courseId), + mutationFn: () => deleteCourseApi(courseId), ... }); return {deleteCourse: mutate, isPending};또는 반환값 이름을
deleteCourseMutation으로 변경하는 방법도 있습니다.Also applies to: 24-24
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/features/course/delete-course/model/useDeleteCourse.ts` at line 2, The imported API function name deleteCourse is shadowed by the returned mutate value which is renamed to deleteCourse; to fix, avoid name collision by renaming one of them (e.g., import { deleteCourse as deleteCourseApi } from '@/entities/course' or return the mutation as deleteCourseMutation) and update all references accordingly (look for the import line referencing deleteCourse and the hook return where mutate is aliased to deleteCourse).src/features/course/create-course/model/courseFormSchema.ts (1)
3-3:YEAR_OPTIONS하드코딩에 대해 고려해 보세요.현재 2026년까지만 포함되어 있어 매년 업데이트가 필요합니다. 현재 연도 기준으로 동적 생성하는 방안을 고려해 볼 수 있습니다.
♻️ 동적 연도 생성 예시
const currentYear = new Date().getFullYear(); export const YEAR_OPTIONS = Array.from( {length: 6}, (_, i) => String(currentYear - 5 + i) ) as unknown as readonly string[];다만, zod enum에서 동적 값을 사용하려면 추가 작업이 필요하므로 현재 방식도 유효합니다.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/features/course/create-course/model/courseFormSchema.ts` at line 3, YEAR_OPTIONS is hardcoded through 2026 which requires yearly updates; replace it with a dynamic generator that builds the array from the current year (e.g., compute currentYear = new Date().getFullYear() and create a sliding window of years of desired length, like last 5 years + current) and assign that result to YEAR_OPTIONS instead of the literal list; keep it typed as a readonly string array (or cast appropriately) so existing zod enum usage (if any) can be adjusted—if zod needs static literal types, keep the current const and add a TODO comment referencing the dynamic approach and handle zod enum changes in a follow-up.src/pages/admin/courses/CourseCreatePage.tsx (1)
16-20:getElementById대신ref사용을 고려해 보세요.DOM을 직접 조회하는 방식은 폼의
id값에 의존하게 되어 결합도가 높아집니다. React의ref를 사용하거나,CourseForm에서 submit 함수를 노출하는 패턴이 더 안전합니다.♻️ ref를 사용한 개선 예시
// CourseForm에서 ref를 통해 submit 노출 const formRef = useRef<HTMLFormElement>(null); // onConfirm에서 사용 onConfirm={() => formRef.current?.requestSubmit()}또는
useImperativeHandle을 활용하여 명시적인 submit 메서드를 노출할 수 있습니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/admin/courses/CourseCreatePage.tsx` around lines 16 - 20, The code in CourseCreatePage uses document.getElementById('course-form') inside the onConfirm handler which couples to a DOM id; replace this with a React ref or an exposed submit method from CourseForm: add a formRef (useRef<HTMLFormElement | null>) in the parent, pass it to CourseForm (or use useImperativeHandle in CourseForm to expose a submit/requestSubmit method), and change onConfirm to call formRef.current?.requestSubmit() or the exposed submit method; update CourseForm props/signature accordingly to accept the ref or imperative handle (refer to CourseCreatePage, CourseForm, formRef, and onConfirm).src/widgets/course-form/ui/CourseForm.tsx (1)
87-91:FileUpload의onFileChange가 빈 함수입니다.현재 파일 선택이 무시되고 있습니다. 의도적인 placeholder라면 TODO 주석을 추가하거나, 기능 구현이 필요하다면 파일 처리 로직을 추가해 주세요.
파일 업로드 기능 구현이 필요하시면 도움을 드릴 수 있습니다. 이 작업을 추적할 이슈를 생성할까요?
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/widgets/course-form/ui/CourseForm.tsx` around lines 87 - 91, The FileUpload's onFileChange is a no-op, so selected files are ignored; implement a handler (e.g., add a handleFileChange function inside CourseForm and pass it to the FileUpload onFileChange prop) that receives the File or FileList, validates type/size, stores the file reference in the form state (or invokes the existing form setValue/dispatch/upload helper used elsewhere in CourseForm), and ensures the file is included when submitting; if this is intentionally not implemented, replace the empty function with a clear TODO comment referencing handleFileChange and a short explanation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@eslint.config.js`:
- Around line 60-82: The boundaries/entry-point rule is set to 'error' which
will break CI due to many existing deep-import violations; change the rule value
for 'boundaries/entry-point' from 'error' to 'warn' to allow a staged migration,
then update imports to re-export via index.ts (fixing deep imports like
entities/auth/model/useUserStore, entities/assignment/api/assignmentQueries,
features/course/create-course/model/courseFormSchema) and once all deep imports
are replaced and verified, flip the rule back to 'error'.
In `@src/entities/course/api/courseApi.ts`:
- Around line 1-4: createCourse와 updateCourse가 현재 서버 응답을 검증하지 않고 raw data를 반환하고
있으니 getAllCourses/getCourseById/deleteCourse에서 사용하는 것과 동일하게
apiResponseSchema(...) 래퍼를 사용해 응답을 검증하도록 변경하세요: HTTP 응답을 받은 후 response.data를
apiResponseSchema(CreateCourseResponse) 등 적절한 제네릭으로 감싸고 .parse(response.data)를
호출해 런타임에서 스키마를 검증한 결과를 반환하도록 createCourse와 updateCourse 로직을 수정하세요.
In `@src/pages/dashboard/ui/CourseCard.tsx`:
- Around line 30-32: Replace the clickable <div> with a semantic <button> to
make the CourseCard keyboard-accessible: change the element that currently has
the onClick handler (the one calling navigate(userType === 'admin' ?
ROUTES.ADMIN.COURSES.DETAIL(id) : ROUTES.STUDENT.COURSES.DETAIL(id))) to a
<button>, preserve the existing className layout classes and add focus classes
(e.g. focus:outline-none focus:ring-2 focus:ring-primary) so focus styles are
visible, and ensure any default button behavior (type="button") is set so
navigation only happens via the onClick handler.
In `@src/shared/config/routes.ts`:
- Around line 8-13: ROUTES.ADMIN.CHAT and ROUTES.ADMIN.ASSIGNMENTS.DETAIL are
defined but not routed; inside the existing <Route path='admin'> block in your
router (where assignments/manage|create|select are registered) add the missing
routes using the same pattern: add a Route with path='chat' rendering your chat
component (e.g., YourChatComponent) and a Route with path='assignments/:id'
rendering AssignmentDetailPage so that navigate(ROUTES.ADMIN.CHAT) and
navigate(ROUTES.ADMIN.ASSIGNMENTS.DETAIL(id)) resolve correctly.
In `@src/shared/ui/ConfirmModal.tsx`:
- Around line 21-38: The ConfirmModal component is missing ARIA dialog
attributes; update the outer container div (the modal root) to include
role="dialog" and aria-modal="true", add an id (e.g. modal-title-<unique>) on
the title element and set aria-labelledby on the dialog to that id, and if
description exists set aria-describedby on the dialog pointing to the
description element id; ensure you reference the ConfirmModal component's root
div, the title element that renders {title}, and the description element that
renders {description} when adding these attributes.
In `@src/shared/ui/LabeledDropdown.tsx`:
- Line 26: The LabeledDropdown component initializes selectedValue with
useState(defaultValue ?? '') which only runs once and causes the dropdown to
stay stale when defaultValue arrives asynchronously; update the component by
adding a useEffect that watches defaultValue and calls
setSelectedValue(defaultValue ?? '') when it changes (optionally guard to only
update when defaultValue is different to avoid overwriting user edits), or
convert LabeledDropdown to a controlled component that takes value and onChange
props and uses defaultValue only as an initial fallback; refer to the
selectedValue/setSelectedValue state and the defaultValue prop in
LabeledDropdown when implementing this change.
In `@src/widgets/course-form/ui/CourseForm.tsx`:
- Around line 77-83: The LabeledInput usage uses identical text for label and
placeholder; update the props passed to the LabeledInput component (the instance
that spreads {...register('description')} and uses
errorMessage={errors.description?.message}) so the label succinctly names the
field (e.g., "강의 소개") and the placeholder provides input guidance (e.g., "강의에 대한
간단한 설명을 입력하세요"); keep the same props order and bindings (label, placeholder,
className, errorMessage, {...register('description')}) and only change the
string values for label and placeholder.
---
Outside diff comments:
In `@src/shared/ui/LabeledInput.tsx`:
- Around line 8-35: The LabeledInput component currently only shows visual
required/error cues; update it to pass accessibility attributes into the <input>
by forwarding the required prop to the input, setting aria-invalid to true when
errorMessage is present, and adding aria-describedby that points to the error
message element. To implement this, ensure the input has an id (use the incoming
rest.id if provided or React's useId() inside LabeledInput to generate one),
render the error <span> with a matching unique id (e.g., `${id}-error`), and set
aria-describedby to that id only when errorMessage exists; keep existing visual
changes intact and reference the LabeledInput props required and errorMessage
and the input/error span identifiers when making the change.
---
Nitpick comments:
In `@src/features/course/create-course/model/courseFormSchema.ts`:
- Line 3: YEAR_OPTIONS is hardcoded through 2026 which requires yearly updates;
replace it with a dynamic generator that builds the array from the current year
(e.g., compute currentYear = new Date().getFullYear() and create a sliding
window of years of desired length, like last 5 years + current) and assign that
result to YEAR_OPTIONS instead of the literal list; keep it typed as a readonly
string array (or cast appropriately) so existing zod enum usage (if any) can be
adjusted—if zod needs static literal types, keep the current const and add a
TODO comment referencing the dynamic approach and handle zod enum changes in a
follow-up.
In `@src/features/course/delete-course/model/useDeleteCourse.ts`:
- Line 2: The imported API function name deleteCourse is shadowed by the
returned mutate value which is renamed to deleteCourse; to fix, avoid name
collision by renaming one of them (e.g., import { deleteCourse as
deleteCourseApi } from '@/entities/course' or return the mutation as
deleteCourseMutation) and update all references accordingly (look for the import
line referencing deleteCourse and the hook return where mutate is aliased to
deleteCourse).
In `@src/pages/admin/courses/CourseCreatePage.tsx`:
- Around line 16-20: The code in CourseCreatePage uses
document.getElementById('course-form') inside the onConfirm handler which
couples to a DOM id; replace this with a React ref or an exposed submit method
from CourseForm: add a formRef (useRef<HTMLFormElement | null>) in the parent,
pass it to CourseForm (or use useImperativeHandle in CourseForm to expose a
submit/requestSubmit method), and change onConfirm to call
formRef.current?.requestSubmit() or the exposed submit method; update CourseForm
props/signature accordingly to accept the ref or imperative handle (refer to
CourseCreatePage, CourseForm, formRef, and onConfirm).
In `@src/shared/lib/handleApiError.ts`:
- Around line 26-29: The current handleApiError function ignores the original
error message when fallbackMessage is provided; update handleApiError to always
capture and log the original API error message from getApiErrorMessage(error)
while still showing the fallbackMessage to the user (use console.error to emit
both the fallbackMessage and the original message/context from
getApiErrorMessage(error) along with the raw error), keep alert(message)
behavior but ensure logging retains full error context so callers using
handleApiError (and functions like getApiErrorMessage) can debug later.
- Around line 6-21: Add handling for HTTP 429 inside getApiErrorMessage: when
axios.isAxiosError(error) detects a response with status === 429 return a clear
rate-limit message (e.g., '요청이 너무 많습니다. 잠시 후 다시 시도해주세요.') and place this check
alongside the other status checks (400, 401, 403, 404, 409, 5xx) so 429 is
matched before the generic fallbacks; keep the rest of the function behavior
unchanged.
In `@src/widgets/course-form/ui/CourseForm.tsx`:
- Around line 87-91: The FileUpload's onFileChange is a no-op, so selected files
are ignored; implement a handler (e.g., add a handleFileChange function inside
CourseForm and pass it to the FileUpload onFileChange prop) that receives the
File or FileList, validates type/size, stores the file reference in the form
state (or invokes the existing form setValue/dispatch/upload helper used
elsewhere in CourseForm), and ensures the file is included when submitting; if
this is intentionally not implemented, replace the empty function with a clear
TODO comment referencing handleFileChange and a short explanation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1f095a1e-705d-4899-854c-d07150295b2c
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (32)
eslint.config.jspackage.jsonsrc/App.tsxsrc/entities/assignment/model/types.tssrc/entities/auth/model/schemas.tssrc/entities/course/api/courseApi.tssrc/entities/course/index.tssrc/entities/course/model/courseSchema.tssrc/entities/course/model/schemas.tssrc/entities/course/model/types.tssrc/features/auth/kakao/model/useKakaoLogin.tssrc/features/course/create-course/model/courseFormSchema.tssrc/features/course/create-course/model/useCreateCourse.tssrc/features/course/delete-course/model/useDeleteCourse.tssrc/features/course/edit-course/model/useEditCourse.tssrc/pages/admin/courses/CourseCreatePage.tsxsrc/pages/admin/courses/CourseEditPage.tsxsrc/pages/common/LandingPage.tsxsrc/pages/common/UserIdInputPage.tsxsrc/pages/dashboard/ui/CourseCard.tsxsrc/pages/dashboard/ui/CourseManagementDropdown.tsxsrc/pages/manage-assignment/ui/AssignmentManageActionsBar.tsxsrc/pages/unit-editor/ui/UnitForm.tsxsrc/shared/config/routes.tssrc/shared/lib/handleApiError.tssrc/shared/ui/BaseHeader.tsxsrc/shared/ui/ConfirmModal.tsxsrc/shared/ui/Header.tsxsrc/shared/ui/LabeledDropdown.tsxsrc/shared/ui/LabeledInput.tsxsrc/widgets/assignment-form-layout/ui/AssignmentFormLayout.tsxsrc/widgets/course-form/ui/CourseForm.tsx
Comment on lines
+77
to
+83
| <LabeledInput | ||
| label='강의 소개를 입력하세요' | ||
| placeholder='강의 소개를 입력하세요' | ||
| className='w-full' | ||
| errorMessage={errors.description?.message} | ||
| {...register('description')} | ||
| /> |
There was a problem hiding this comment.
라벨과 플레이스홀더가 동일합니다.
label은 필드의 역할을 설명하고, placeholder는 입력 예시를 보여주는 것이 UX 관점에서 좋습니다. 예: label="강의 소개", placeholder="강의에 대한 간단한 설명을 입력하세요".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/widgets/course-form/ui/CourseForm.tsx` around lines 77 - 83, The
LabeledInput usage uses identical text for label and placeholder; update the
props passed to the LabeledInput component (the instance that spreads
{...register('description')} and uses
errorMessage={errors.description?.message}) so the label succinctly names the
field (e.g., "강의 소개") and the placeholder provides input guidance (e.g., "강의에 대한
간단한 설명을 입력하세요"); keep the same props order and bindings (label, placeholder,
className, errorMessage, {...register('description')}) and only change the
string values for label and placeholder.
suminb99
approved these changes
Mar 15, 2026
Contributor
suminb99
left a comment
suminb99
left a comment
There was a problem hiding this comment.
확인했습니다!
이번 PR 리뷰 저에게도 정말 많은 도움이 됐습니다. 정말 수고많으셨어요!! 😆
| title: data.title, | ||
| section: data.section, | ||
| year: String(data.year) as CourseFormValues['year'], | ||
| semester: SEMESTER_DISPLAY_MAP[data.semester], |
Contributor
There was a problem hiding this comment.
SEMESTER_DISPLAY_MAP을 정의해서 사용하는 대신 기존의 formatSemester 함수를 활용하는 방식도 고려해볼 수 있을 것 같아요. 어차피 서버에서 내려오는 값은 고정되어 있고, 프론트에서도 드롭다운으로 선택되게 처리해서 고정된 4가지 값 외에는 들어올 수 없으니까요. 사용자를 위한 표시용 변환이라면 formatSemester로 충분할 것 같습니다.
semester: formatSemester(data.semester)
Comment on lines
+13
to
+18
| export const SEMESTER_DISPLAY_MAP = Object.fromEntries( | ||
| Object.entries(SEMESTER_CODE_MAP).map(([display, code]) => [code, display]) | ||
| ) as Record< | ||
| (typeof SEMESTER_CODE_MAP)[keyof typeof SEMESTER_CODE_MAP], | ||
| keyof typeof SEMESTER_CODE_MAP | ||
| >; |
Contributor
There was a problem hiding this comment.
아래 CourseEditPage.tsx 리뷰 참고해 주세요!
This was referenced Mar 15, 2026
Merged
This was referenced Mar 22, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚙️ Related ISSUE Number
closed #53
📄 Work Description
1. API 엔드포인트 중앙화 및 리팩토링
assignmentApi.ts,authApi.ts,courseApi.ts,unitApi.ts내의 모든 API 호출이@/shared/config/endpoints에 정의된ENDPOINTS객체를 사용하도록 리팩토링되었습니다. 하드코딩된 URL 문자열을 대체함으로써 유지보수성을 높였습니다.2. 코스 관리 기능 추가
createCourse,updateCourseAPI와 관련 요청/응답 스키마, TypeScript 타입을 추가했습니다. 또한, 앱 전체에서 사용할 수 있도록 모듈 인덱스에서 이를 내보내기(export) 하도록 설정했습니다.Schedule,Unit,BaseCourse,CourseOverview등 코스 관련 엔티티에 대한 포괄적인 TypeScript 인터페이스를 정의하여 코드의 명확성과 타입 안정성을 확보했습니다.3. ESLint 설정 및 프로젝트 구조 강제화
eslint-plugin-boundaries와@feature-sliced/steiger-plugin을 설정했습니다. 이를 통해app,pages,widgets,features,entities,shared계층 간의 임포트를 제한하는 상세 규칙을 적용했습니다.zod등 기존 라이브러리를 업데이트했습니다.4. 인증 및 카카오 로그인 리팩토링
entities/auth에서features/auth/kakao로 이동하고,authMutations를kakaoMutations로 이름을 변경하여 역할을 명확히 분리했습니다.studentId가null이 될 수 있도록 허용하여 예외 상황에 대한 대응력을 높였습니다. 또한, 로그인 훅 내의 내비게이션 로직이 중앙화된ROUTES객체를 사용하도록 업데이트했습니다.5. 기타 개선 사항
App.tsx에서 코스 편집 경로를 지원하고 관련 페이지 임포트 경로를 수정했습니다.📷 Screenshot
💬 To Reviewers
🔗 Reference