Introduce PeerId for stricter type meaning across the crate#286
Merged
rustaceanrob merged 2 commits intomasterfrom Feb 7, 2025
Merged
Introduce PeerId for stricter type meaning across the crate#286rustaceanrob merged 2 commits intomasterfrom
PeerId for stricter type meaning across the crate#286rustaceanrob merged 2 commits intomasterfrom
Conversation
nyonson
reviewed
Feb 7, 2025
|
|
||
| use crate::core::messages::RejectPayload; | ||
|
|
||
| use super::PeerId; |
Collaborator
There was a problem hiding this comment.
I don't see super used much beyond unit test modules pulling in the code they are testing. I think it is a little less maintainable then a full crate namespace? Not a blocker or anything, just curious on the style.
Collaborator
Author
There was a problem hiding this comment.
Just the LSP auto complete. Could potentially make an issue for a greater refactor to tackle then. super is used quite a bit across the crate.
Collaborator
Author
There was a problem hiding this comment.
I will go ahead and punt on this here, but feel free to make a meta issue.
nyonson
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a
u32nonce that is used to identify peers when we open a connection to them and want to send a specific peer a message. Refactoring this to a wrapper type is hopefully easier to read, especially for folks not familiar with the library but would potentially want to submit a patch.You'll notice I used
wrapping_addto prevent an overflow as well. Funny enough Bitcoin Core had the same problem of using plain oldu32math that could be exploited.cc @nyonson