Skip to content

feat: quiver and PS vs z plot#39

Merged
DanielaBreitman merged 16 commits intomainfrom
quiver
Jul 11, 2025
Merged

feat: quiver and PS vs z plot#39
DanielaBreitman merged 16 commits intomainfrom
quiver

Conversation

@DanielaBreitman
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (572873d) to head (1fca63e).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/tuesday/core/plotting/powerspectra.py 91.89% 0 Missing and 3 partials ⚠️
src/tuesday/core/plotting/sliceplots.py 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   84.53%   85.44%   +0.90%     
==========================================
  Files          11       11              
  Lines         692      742      +50     
  Branches      170      188      +18     
==========================================
+ Hits          585      634      +49     
  Misses         44       44              
- Partials       63       64       +1     
Flag Coverage Δ
unittests 85.44% <90.74%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would split the power vs z and power vs k functions. Other than that, a few small comments.

Comment thread src/tuesday/core/plotting/sliceplots.py Outdated
Comment thread src/tuesday/core/plotting/sliceplots.py Outdated
Comment thread src/tuesday/core/plotting/sliceplots.py Outdated
Comment thread src/tuesday/core/plotting/powerspectra.py
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Copy Markdown
Member

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a couple of small issues in the 1D plot vs z, shouldn't be hard to fix

Comment thread src/tuesday/core/plotting/powerspectra.py Outdated
Comment thread src/tuesday/core/plotting/powerspectra.py Outdated
Comment thread src/tuesday/core/plotting/powerspectra.py Outdated
Comment thread src/tuesday/core/plotting/powerspectra.py Outdated
Comment thread src/tuesday/core/plotting/powerspectra.py Outdated
@DanielaBreitman DanielaBreitman merged commit 8b791f5 into main Jul 11, 2025
22 checks passed
@DanielaBreitman DanielaBreitman deleted the quiver branch July 11, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants