feat: Add preference to disable Co-Authored-By attribution

[aadivar]

Summary

• Adds a toggle in Settings > Preferences to control whether Claude adds "Co-authored-by: Claude" to git commits
• The setting is stored in ~/.claude/settings.json using the standard includeCoAuthoredBy option that Claude Code respects
• Toggle is ON by default (co-authored-by is included), users can disable it if they prefer clean commit histories

Changes

• New tRPC router (claudeSettings) with endpoints to read/write the includeCoAuthoredBy setting
• New "Git" section in Preferences tab with the toggle
• Uses Claude Code's native settings file so the preference works consistently

Test plan

• Open Settings > Preferences
• Toggle "Include Co-Authored-By" off
• Verify ~/.claude/settings.json contains "includeCoAuthoredBy": false
• Have Claude make a commit and verify no co-authored-by line
• Toggle back on and verify the setting is removed from settings.json (uses default)

[bunasQ]

@1code check this pr, is this legit fix? look at the codebase

i also see that it has some conflicts with main, what's the problem there?

do deep investigation and put a lot of reasoning tokens into it

[1code-async]

Task completed.

Based on my investigation, I have important findings to share:

CRITICAL FINDING: PR #56 Does Not Exist in This Repository

After thorough investigation, I've discovered that Pull Request #56 does not exist in the 21st-dev/1code repository. Here's what I found:

🔍 Investigation Summary

1. Branch doesn't exist: The branch feature/disable-coauthored-by-clean is not present in the repository (neither locally nor remotely)

2. No commits from author: There are no commits from @aadivar in the entire git history

3. No related code found: Searching the codebase for:

   • Co-Authored-By - No matches
   • includeCoAuthoredBy - No matches
   • claudeSettings router - No matches
   • ~/.claude/settings.json handling - No matches

4. Repository mismatch: The user mentioned bunasQ/21st-agents but you're actually in the 21st-dev/1code repository

5. Current state: The main branch is clean with the latest release being v0.0.27

📊 What Does Exist in the Codebase

Looking at the actual Claude integration code (src/main/lib/trpc/routers/claude.ts), I can see:

• Current implementation: Claude commits currently include the Co-Authored-By attribution by default
• No settings infrastructure: There's no existing claudeSettings router or settings.json handling
• Settings UI exists: There is a preferences tab (agents-preferences-tab.tsx) but it only handles:
  • Extended thinking toggle
  • Sound notifications
  • Keyboard shortcuts
  • Analytics opt-out

❓ Possible Scenarios

1. Wrong repository: The PR might exist in a different fork or repository
2. Future/planned PR: The PR might be planned but not yet created
3. Deleted/closed PR: The PR might have been closed and deleted
4. Miscommunication: There might be confusion about the PR number or repository

🎯 What Would a Legitimate Implementation Look Like?

If this were a real feature request, a proper implementation would need:

1. New tRPC router (claudeSettings) with endpoints to:

   • Read ~/.claude/settings.json
   • Write the includeCoAuthoredBy setting

2. UI changes in agents-preferences-tab.tsx:

   • Add a "Git" section
   • Add a toggle for "Include Co-Authored-By in commits"

3. Claude SDK integration: The SDK already supports the includeCoAuthoredBy setting via ~/.claude/settings.json

4. File locations (if it existed):

   • src/main/lib/trpc/routers/claude-settings.ts (new router)
   • src/renderer/components/dialogs/settings-tabs/agents-preferences-tab.tsx (UI update)

🚩 Merge Conflicts?

You asked about merge conflicts - there can't be any merge conflicts because the branch doesn't exist in this repository.

---

Recommendation: Please verify:

1. The correct repository URL
2. The correct PR number
3. Whether this is in a fork or a different project entirely

Would you like me to check if there's a different repository or fork where this PR might exist?

---

View full conversation

Powered by 1Code

[aadivar]

The fix is legitimate. Here's the breakdown:

Implementation:

• Creates claude-settings.ts router that reads/writes ~/.claude/settings.json
• Uses the standard includeCoAuthoredBy key that Claude Code SDK respects
• Adds a toggle in Settings → Preferences under a new "Git" section
• Default is ON (co-authored-by included), users can disable for cleaner commit histories

Merge conflicts (now resolved):

• Upstream added ollamaRouter and commandsRouter since this PR was created
• Rebased on latest upstream/main - both new routers are preserved alongside claudeSettingsRouter

Note on the automated response: The @1code-async comment was incorrect - it claimed the PR/branch doesn't exist, but it clearly does. The bot may have been checking the wrong repo or branch.

[1code-async]

@aadivar Sorry, only collaborators with write access can trigger @1code.