Fix Windows PATH resolution for packaged apps #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add buildWindowsPath() to derive PATH from process.env + common locations - Include ~/.local/bin, Git for Windows paths, and System32 - Case-insensitive deduplication for Windows paths - Skip login shell spawn on Windows (Git Bash PATH excludes user paths) Fixes packaged apps on Windows not finding user-installed tools like Claude CLI.
prathamdby
changed the title
Author
|
Before: After: |
Contributor
|
Thank you for this contribution! We've manually integrated your changes in commit a4bfdbd7c (synced from upstream). The PR has merge conflicts due to overlapping changes from #72 that were merged earlier. Since we've already incorporated your improvements (buildWindowsPath function, common Windows paths, case-insensitive deduplication), we'll close this PR. Your changes are now live in the codebase. Thanks again! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 1Code on Windows not finding user-installed tools like Claude CLI when running as a packaged app.
Problem
On Windows, spawning a Git Bash login shell to capture PATH doesn't include Windows user paths like
~/.local/bin. This causes 1Code to fail when trying to execute Claude agents or git-lfs operations.Solution
buildWindowsPath()to derive PATH fromprocess.env.PATH+ common install locations~/.local/bin(where Claude CLI is often installed), Git for Windows paths, and System32macOS/Linux behavior unchanged. Still spawns login shell to capture profile-defined PATH.
Changes
src/main/lib/git/shell-env.ts: Platform-specific PATH resolution