Fix: Implement save_chat_messages in SQLChatStorage and Improve Reliability#201
Merged
Conversation
- Added initialization method for SqlChatStorage to ensure proper setup before use. - Updated documentation to include examples for both TypeScript and Python, emphasizing the need for initialization. - Improved error handling and resource management in the save_chat_message and save_chat_messages methods. - Introduced batch operations for saving multiple messages efficiently. - Enhanced message validation and cleanup of old messages based on max_history_size. - Updated best practices section in documentation to reflect new features and usage patterns.
- Added comprehensive test suite for SqlChatStorage, covering message saving, fetching, and handling of multiple users and sessions. - Implemented tests for message ordering, transaction rollback, and concurrent access to ensure robust database interactions. - Updated test_requirements.txt to include 'libsql-client' alongside 'openai' for enhanced testing capabilities.
5 tasks
Contributor
Author
|
@cornelcroi Let me know if there are any additional test cases that need to be added. |
Rajaniraiyn
changed the title
save_chat_messages in SQLChatStorage and Improve Reliability
cornelcroi
approved these changes
Jan 10, 2025
Collaborator
|
Thanks @Rajaniraiyn |
|
@cornelcroi is there a new package version? I have this with the same error - "multi-agent-orchestrator[sql]>=0.1.4", was on 0.1.3 earlier |
Collaborator
|
Yes 0.1.5 |
Collaborator
|
Works, thanks @cornelcroi @Rajaniraiyn ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #111 (comment)
Summary
Changes
save_chat_messages, introduced in commit cd46dad but previously missing inSQLChatStorage.SQLChatStorageimplementation.User Experience
SQLChatStorageto safeguard against future breaking changes.Checklist
If your change doesn't seem to apply, please leave it unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.