Fix security vulnerabilities in install-trivy and run-trivy#12
Merged
JasonPierce merged 6 commits intomainfrom Apr 3, 2026
Merged
Fix security vulnerabilities in install-trivy and run-trivy#12JasonPierce merged 6 commits intomainfrom
JasonPierce merged 6 commits intomainfrom
Conversation
Use ${VAR:+--flag "$VAR"} for skip_dirs/skip_files to prevent word
splitting, and wrap Trivy output in ::stop-commands:: guards to prevent
workflow command injection via log output.
…all-trivy Move version input to env var to prevent code injection, replace deprecated apt-key with gpg --dearmor into /etc/apt/keyrings, and use tee without -a to avoid duplicate sources list entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_dirs/skip_filesby using${VAR:+--flag "$VAR"}parameter expansion::stop-commands::guardsinstall-trivyby movingversioninput to env varapt-keywithgpg --dearmorinto/etc/apt/keyrings/-aflag fromteeCloses #11
Test plan
run-trivyscan works withskip_dirsandskip_filescontaining spaces::stop-commands::guardsinstall-trivyinstalls the correct version via env varinstall-trivyworks on Ubuntu 22.04+ runners with new keyring approachinstall-trivytwice doesn't create duplicate sources entries