Conversation
marijanbrvar
left a comment
marijanbrvar
left a comment
There was a problem hiding this comment.
Great Work. I found your code readable, and there are no many things I would suggest to change, anyways my suggestion is, it will improve code readability a lot, which is the basic principle of code duty separation. Just group DOM manipulation in function and not mix logic and dom manipulation.
| const list = []; | ||
| let displayedList; | ||
|
|
||
| const todoList = (arr) => { |
There was a problem hiding this comment.
Great Work. I found your code readable, and there are no many things I would suggest changing, anyways. My suggestion is, it will improve code readability a lot, which is the basic principle of code duty separation. Just group DOM manipulation in function and not mix logic and dom manipulation.
You can use string interpolation or separate code related to dom element creation and styling in another function than the call function. Of course, this is just an optional suggestion.
Great work, my friend!
2 participants
In this PR we:
Commit to-do-list exercise as one big chunk of code in a feature branch for JS best practice review.