fix(rfc9111): implement must-understand and no-store interaction per RFC 9111 Section 5.2.2.3 #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RFC 9111 Section 5.2.2.3 According to RFC 9111 Section 5.2.2.3, when a cache that implements the must-understand directive receives a response that includes it, the cache SHOULD ignore the no-store directive if it understands and implements the status code's caching requirements. This change modifies the Storable() method to ignore no-store when: - must-understand directive is present - AND the cache understands the response status code Added test cases to verify the behavior: - Status 200 with must-understand + no-store -> cacheable - Status 418 with must-understand + no-store -> cacheable - Status 299 (unknown) with must-understand + no-store -> not cacheable
Contributor
Code Metrics Report
Details | | main (cf0ad24) | #98 (a91230c) | +/- |
|---------------------|----------------|---------------|-------|
+ | Coverage | 61.7% | 62.0% | +0.2% |
| Files | 8 | 8 | 0 |
| Lines | 513 | 514 | +1 |
+ | Covered | 317 | 319 | +2 |
+ | Code to Test Ratio | 1:2.3 | 1:2.4 | +0.0 |
| Code | 853 | 854 | +1 |
+ | Test | 2029 | 2077 | +48 |
- | Test Execution Time | 1m0s | 1m2s | +2s |Code coverage of files in pull request scope (78.5% → 79.0%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 9111 Section 5.2.2.3, when a cache that implements the
must-understand directive receives a response that includes it, the cache
SHOULD ignore the no-store directive if it understands and implements the
status code's caching requirements.
This change modifies the Storable() method to ignore no-store when:
Added test cases to verify the behavior: