There are cases where I want to use keys other than the fixed ones. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1LoW
approved these changes
Dec 23, 2023
Member
k1LoW
left a comment
k1LoW
left a comment
There was a problem hiding this comment.
LGTM.
We need to choose host or remote_addr, right?
base_limiter.go
Outdated
| return false | ||
| } | ||
| func validateKey(key string) error { | ||
| for _, k := range []string{"remote_addr", "host"} { |
Member
There was a problem hiding this comment.
"remote_addr" and "host" may be const variables.
Contributor
Author
There was a problem hiding this comment.
I see.
I should to make constaiant variable host and remote_addr.
I will do afer cristmas..
Contributor
Author
Yes!!! |
k1LoW
reviewed
Dec 23, 2023
Co-authored-by: Ken’ichiro Oyama <k1lowxb@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made adjustments because there are cases where I want to block not just based on the host, but also on IP for limiters of GET parameters and request paths.