Skip to content

feat: removed bubble window#208

Merged
2ndalpha merged 1 commit intomasterfrom
siim_bubble
Sep 3, 2022
Merged

feat: removed bubble window#208
2ndalpha merged 1 commit intomasterfrom
siim_bubble

Conversation

@2ndalpha
Copy link
Owner

@2ndalpha 2ndalpha commented Sep 3, 2022

No description provided.

@2ndalpha 2ndalpha marked this pull request as ready for review September 3, 2022 05:54
@2ndalpha 2ndalpha merged commit a8e7d37 into master Sep 3, 2022
@2ndalpha 2ndalpha deleted the siim_bubble branch September 3, 2022 05:54
2ndalpha added a commit that referenced this pull request Mar 1, 2026
Restore the error/offline info bubble that was accidentally removed in
PR #208 when InfoBubble was deleted. Replace the legacy MAAttachedWindow
(2007 3rd-party ObjC library) with native SwiftUI .popover() modifiers
on badge icons in HostsRowView.

- Add ErrorPopoverView showing error title, description, and optional
  "Open in Browser" button
- Make error and offline badge icons tappable with popover details
- Remove dead MAAttachedWindow and NSToolbarPoofAnimator files
- Clean up dead code in ListController.m left behind by PR #208
  (showEditError:, locationOfHosts:, handleHostsFileRemoval:, etc.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant