Conversation
|
Thank you very much! I've fixed some indentations, added some test cases and fixed the documentation issues.
Anyway would adding
to the end of https://github.com/2pi/karnaugh-map/blob/master/README.md#license suffice as attribution? And therefore changing the top part of the karnaugh-map.dtx file similarly. Finally changing the copyright line to
|
|
I am open to any solution regarding license and acknowledgement. While not fully understanding (going into details) the license issue, trusting you fully there, I think your acknowledgement suggestion sounds just fine. Maybe updating the copyright year? |
|
Great, thanks! To be honest I've a hard time understanding it myself, this is the main reason the initial release was delayed about a year. However to my understanding this is how it supposed to work. I'll fix the year too. |
Update attributions and copyright notice in accordance with the pr/issue discussion in 2pi#7
|
Thanks for your contribution 👍 |
Replaces #6 by introducing
\terms{cells}{content}.\minterms,\maxterms, and\indeterminantsnow use\termsunderneath.An example is also added to the manual, but due to a line break, it does not look so good.
No explicit tests (although I got slightly longer in the test now, diff-pdf was missing and I'm currently not in the situation to be able install it properly).