HTML form gen fix crash when required prop is not defined#300
Merged
MaddyUnderStars merged 1 commit intodevelopfrom May 9, 2024
Merged
HTML form gen fix crash when required prop is not defined#300MaddyUnderStars merged 1 commit intodevelopfrom
required prop is not defined#300MaddyUnderStars merged 1 commit intodevelopfrom
Conversation
|
Additional Context: When approving a saved article, the following error would be logged: Maddy has made the changes described above and I can confirm that the error above no longer appears in the logs and the article successfully publishes to the dev website. The security tab and MFA fixes are still present. |
DaltJM
approved these changes
May 9, 2024
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Dalton found a crash in the AEC modules where a html form was being generated but
$field->requiredwasn't defined and the generator doesn't check it exists before accessing it.This has been tested by Dalton and I on my local system and the dev aec instance
Changelog
refs:
issues:
Other Information
Docs pull request: