feat: sync prompt on workspace close#135
Merged
Merged
Conversation
window.emit() broadcasts to all windows, causing other workspaces to receive the close event and potentially close themselves. Use emit_to() to target only the window being closed.
The global listen() from @tauri-apps/api/event receives events from all windows. Switch to getCurrentWebviewWindow().listen() which only receives events targeted at the current window, preventing one window's close from triggering the handler in another window.
The pending-ops check counted ALL operations after the watermark, but operations_since() (used by generate_delta) excludes ops authored by the peer and ops received from the peer (echo prevention). This caused false positives where the check reported pending work but poll_sync found nothing to send. Apply the same device_id and received_from_peer filters to the COUNT query so the check agrees with the actual sync behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_pending_sync_opswhich filters them out)has_pending_ops_for_any_peer()now applies the same device_id and received_from_peer filters asoperations_since(), resolving false positives where the check reported pending work butpoll_syncfound nothing to sendChanges
has_pending_ops_for_any_peerto exclude peer-authored and echo ops from countsync_on_closesetting inAppSettings,CloseRequestedinterception viaclosing_windowsset,close_windowTauri commandSyncOnCloseDialogcomponent,useSyncOnClosehook with cancellation guard, Settings dropdownTest plan