fix: add ZIP integrity verification for .swarm and .krillnotes files#193
Merged
Conversation
Catch CRC32 checksum mismatches and deflate stream corruption during ZIP entry reads in both invite (.swarm) and export (.krillnotes) paths, replacing generic I/O errors with user-facing corruption messages. Closes #180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invite.rs(read_json_from_zip_bytes) andexport.rs(read_entry)Test plan
corrupted_zip_gives_clear_error— flips bytes in compressed payload, asserts "corrupted" in error messagetruncated_zip_gives_clear_error— garbage ZIP bytes, asserts "Cannot read .swarm bytes" errorzip_round_trip_in_memory— existing test still passes (no regression)cargo test -p krillnotes-core— 642 tests passcargo clippyandcargo fmt --checkcleanCloses #180