ai: disable claude code review #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Hi @2sem, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This Pull Request successfully disables the Claude code review workflow in favor of Gemini. The changes are minimal, safe, and correctly handle the transition to comment-based triggers (even though the job is currently disabled).
🔍 General Feedback
- The use of
if: falseis a clean way to temporarily disable the automation without deleting the configuration. - Trigger and PR number logic updates are well-implemented and compatible with GitHub's event structure for issues and pull requests.
| # github.event.pull_request.user.login == 'new-developer' || | ||
| # github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' | ||
|
|
||
| if: false |
There was a problem hiding this comment.
🟢 Using `if: false` is a simple and effective way to disable the job while keeping the configuration intact for future use. Note that the workflow will still trigger on the specified events but will be marked as skipped in the Actions tab.
| REPO: ${{ github.repository }} | ||
| PR NUMBER: ${{ github.event.pull_request.number }} | ||
| PR NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }} | ||
There was a problem hiding this comment.
🟢 This logic robustly handles different event types. Specifically, `issue_comment` on a Pull Request uses `github.event.issue.number`, while `pull_request` and `pull_request_review` events use `github.event.pull_request.number`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable claude code review
to review by gemini