fix: defer push notifications + remove SMS sharing docs#13
Merged
GraysonCAdams merged 3 commits intomainfrom Mar 1, 2026
Merged
fix: defer push notifications + remove SMS sharing docs#13GraysonCAdams merged 3 commits intomainfrom
GraysonCAdams merged 3 commits intomainfrom
Conversation
Previously, push notifications for new clips fired immediately after clip creation — before the download even started. If the download failed, users had already been notified about a clip that would never be ready. Now notifications are sent from the download pipeline after status is set to 'ready'. Failed downloads produce no notification.
Twilio is only used for phone verification codes, not for video/music ingestion via SMS. Updated all docs to reflect this: CLAUDE.md, architecture, data model, deployment guides, features, notifications, and platform support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status: 'ready'), not immediately on clip creation. Failed downloads no longer produce ghost notifications.Test plan