fix: keep activity notifications until manually dismissed#149
Merged
GraysonCAdams merged 5 commits intomainfrom Apr 14, 2026
Merged
fix: keep activity notifications until manually dismissed#149GraysonCAdams merged 5 commits intomainfrom
GraysonCAdams merged 5 commits intomainfrom
Conversation
Notifications in the activity feed now persist until the user taps the X button. Watching a clip and viewing its comments only mark the related notifications as read (removing the unread tint and badge) instead of deleting them outright.
Favoriting previously always inserted a paired ❤️ reaction, even when the user already had a non-❤️ reaction (e.g. 🔥). That left two reaction rows for the same user/clip, and the comments view — which dedupes to the latest reaction per user — showed ❤️ instead of their chosen emoji. Now favorite only creates a ❤️ reaction when the user has no existing reaction. If they've already reacted with any emoji, we preserve it and just mark the clip as favorited, maintaining the one-reaction-per-user invariant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Xbutton./activitysincegotopushes a history entry — no additional work needed.Test plan
Xon a notification → row disappears, unread count decrements if it was unread