fix: simplify release workflow, remove GITHUB_TOKEN workarounds#17
Merged
GraysonCAdams merged 1 commit intomainfrom Mar 1, 2026
Merged
fix: simplify release workflow, remove GITHUB_TOKEN workarounds#17GraysonCAdams merged 1 commit intomainfrom
GraysonCAdams merged 1 commit intomainfrom
Conversation
Strip out anti-patterns from the release workflow: - Remove fake status check injection via commit status API - Remove inline CodeQL job for release PRs - Remove inline Docker build job These were workarounds for GITHUB_TOKEN not triggering other workflows. The proper fix is a GitHub App token (documented in TODO comment). Restore docker-publish.yml with both release event trigger and manual workflow_dispatch fallback, with proper version extraction for release-please's scrolly-v* tag format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release: publishedandworkflow_dispatchtriggersactions/create-github-app-tokenWhy
The previous iterations layered workarounds for GITHUB_TOKEN not triggering workflows. The right fix is a GitHub App token, which makes everything work naturally. Until that's set up, releases and Docker publishes can be done manually.
Test plan