fix: auto-trigger CI and Docker publish for release-please PRs#21
Merged
GraysonCAdams merged 2 commits intomainfrom Mar 1, 2026
Merged
fix: auto-trigger CI and Docker publish for release-please PRs#21GraysonCAdams merged 2 commits intomainfrom
GraysonCAdams merged 2 commits intomainfrom
Conversation
release-please uses GITHUB_TOKEN which doesn't trigger other workflows. This caused release PRs to have no status checks, blocking merges when branch protection requires them. Fix with three changes: - Add release-pr-checks.yml using pull_request_target (which IS triggered by GITHUB_TOKEN) to run CI and CodeQL on release-please PRs - Add workflow_run trigger to docker-publish.yml so Docker images are automatically published when release-please creates a release - Clean up stale TODO comments in release.yml
Repository rules require CodeQL results for all PRs, even when only workflow YAML files are changed. Previously CodeQL was skipped when the paths filter found no security-relevant files, which blocked merging workflow-only PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-pr-checks.ymlusingpull_request_targetto run CI and CodeQL on release-please PRsworkflow_runtrigger todocker-publish.ymlfor automatic Docker image publishing after releasesrelease.ymlProblem
release-please uses
GITHUB_TOKENto create PRs and releases. GitHub Actions does not trigger workflows fromGITHUB_TOKENevents (to prevent recursive runs). This means:workflow_dispatchSolution
pull_request_targetIS triggered byGITHUB_TOKENevents (it runs in the base branch context). A new workflow uses this to run CI + CodeQL specifically on release-please PRs.workflow_runIS triggered byGITHUB_TOKENworkflow completions. Docker publish now watches for the Release workflow to complete and checks if a new version needs publishing.Test plan
workflow_dispatchstill works as fallback