feat: feed sort, push test, shortcut validation, scroll polish#33
Merged
GraysonCAdams merged 9 commits intomainfrom Mar 1, 2026
Merged
feat: feed sort, push test, shortcut validation, scroll polish#33GraysonCAdams merged 9 commits intomainfrom
GraysonCAdams merged 9 commits intomainfrom
Conversation
Replace hardcoded env(safe-area-inset-bottom) calculations with a measured --bottom-nav-height CSS variable, adapting to real device safe-area insets automatically.
Add a per-user feed sort preference (oldest-first or round-robin) stored in the users table. Round-robin interleaves clips from different members so no single poster dominates the feed. Watched tab always sorts by most-recently-watched regardless of preference.
Add a test notification endpoint and UI button in notification settings so users can verify their push setup is working. Includes a 10-second server-side delay and 24-hour cooldown display.
Validate iCloud shortcut URLs before saving by hitting a validation endpoint first. Show blockers, soft warnings, and unreachable states with appropriate save/retry actions. Extract ValidationResults into a shared component to keep ShortcutManager under the line limit.
Switch brand icon from img element to inline SVG with currentColor so it inherits the group accent color dynamically.
Point push notification icon and badge to the new SVG icon paths.
Add one-reel-at-a-time wheel scrolling to prevent trackpad inertia from skipping multiple reels. Enable scroll-snap-stop: always, hide the scrollbar, and navigate to the correct filter tab on deep-link.
Move the iOS shortcut sheet content (iCloud URL input, validation, token management) into a dedicated ShortcutSheet component to keep ShortcutManager under the line limit.
Adjust clip tests to match the new behavior where only ready clips appear in the feed. Add a second ready clip to the seed for pagination coverage and simulate download completion in the auto-watched test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env(safe-area-inset-bottom)with a ResizeObserver-measured--bottom-nav-heightCSS variable across all overlay components.scroll-snap-stop: always, hidden scrollbar, correct filter tab on deep-link navigation.currentColorfor dynamic accent color.Test plan