refactor(protocol): prune grpc-gateway related proto#72
refactor(protocol): prune grpc-gateway related proto#72
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 41 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request removes Go package generation directives and HTTP/REST gateway annotations from proto files. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Closes tronprotocol#6548.
Removes all
google.api.httpoption annotations from gRPC service definitions and deletes eight unused empty proto files underprotocol/src/main/protos/core/tron/. No RPC method signatures, message types, or service interfaces are changed.Background
The grpc-gateway project, which relied on
google.api.httpmappings to translate HTTP requests into gRPC calls, has been deprecated and is no longer maintained. Every gRPC API already has a dedicated HTTP implementation inFullNodeHttpApiService, making the dual HTTP-REST route definitions redundant. Retaining them adds maintenance overhead and cognitive complexity without providing value.Changes
protocol/src/main/protos/api/api.protogoogle.api.httpoption blocks from 56 RPC methods across theWallet,WalletSolidity,WalletExtension, andMonitorservices.option go_packagedeclarations from API and contract proto files.Deleted files (
protocol/src/main/protos/core/tron/)Eight empty proto files that served no purpose after grpc-gateway was abandoned:
account.protoblock.protodelegated_resource.protop2p.protoproposal.prototransaction.protovote.protowitness.protoImpact
FullNodeHttpApiServiceand are unaffected.option go_packagehas been removed; Go client stubs can no longer be generated directly from these proto files.Test
NA — this is a pure proto cleanup with no logic changes. The generated Java/gRPC stubs are functionally identical.