build: update organization name and repository URLs in pom.xml #1
Conversation
…sion file Remove GitHub Actions workflow for dependency review and dependency-check suppression file as they are no longer required. Update CodeQL workflow to use JDK 21.
Update GitHub Actions workflows to use JDK 21 and remove JDK 17 configurations.
There was a problem hiding this comment.
Pull request overview
This PR updates the project's organization identity and upgrades the Java version. The main changes include updating the organization name from "CashuTools" to "398ja" in pom.xml, updating all SCM repository URLs, upgrading the Java version from 17 to 21 across GitHub Actions workflows, bumping the nostr-java dependency from 1.1.0 to 1.2.0, and removing dependency security scanning workflows and configuration files.
Key Changes:
- Organization name and repository URLs updated from cashutools to 398ja
- GitHub Actions workflows upgraded to use JDK 21 instead of JDK 17
- nostr-java dependency bumped from 1.1.0 to 1.2.0
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated organization name to "398ja", updated SCM URLs, and bumped nostr-java version to 1.2.0 |
| .github/workflows/release.yml | Updated JDK version from 17 to 21 in both release and deploy jobs |
| .github/workflows/codeql.yml | Updated JDK version from 17 to 21 for security analysis |
| .github/workflows/ci.yml | Updated JDK version from 17 to 21 and removed Java 17 from build matrix |
| dependency-check-suppressions.xml | Removed OWASP dependency check suppressions configuration file |
| .github/workflows/dependency-review.yml | Removed dependency review and OWASP dependency check workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update GitHub Actions workflows to use JDK 21 and remove JDK 17 configurations.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <maven.compiler.source>21</maven.compiler.source> | ||
| <maven.compiler.target>21</maven.compiler.target> | ||
| <java.version>21</java.version> |
There was a problem hiding this comment.
The PR title mentions updating organization name and repository URLs, but the changes also include upgrading Java from version 17 to 21 and updating the nostr-java dependency from 1.1.0 to 1.2.0. These significant changes should either be mentioned in the PR title/description or split into separate commits/PRs for better change tracking and easier rollback if needed.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| strategy: | ||
| matrix: | ||
| java-version: [ '17', '21' ] | ||
| java-version: [ '21' ] |
There was a problem hiding this comment.
Removing the entire CI matrix for testing multiple Java versions (previously 17 and 21, now only 21) reduces test coverage. This change means the project will no longer verify compatibility with Java 17, which could be breaking for existing users. Consider maintaining Java 17 in the test matrix if backward compatibility is still supported, or clearly document this as a breaking change requiring Java 21 as the minimum version.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
No description provided.