Use UTF8, make UnitTests platform independent and remove more broken code#83
Merged
martinweismann merged 14 commits intomasterfrom May 23, 2018
Merged
Use UTF8, make UnitTests platform independent and remove more broken code#83martinweismann merged 14 commits intomasterfrom
martinweismann merged 14 commits intomasterfrom
Conversation
3dJan
pushed a commit
to 3dJan/lib3mf
that referenced
this pull request
Apr 27, 2023
…code (3MFConsortium#83) * First working UTF8-implementation * Remove unused code im xml-reader * Remove plenty of unused 'GCC'-code * Port VS unittests to gtest * Make UTF8-changes and UnitTests compile on linux * Fix MAC build * Address some TODOs * Remove broken COM-functionality * Change some more interfaces to UTF8 * Remove unsused includes and NMR_COM_NATIVE flags * Up the version number * Remove ATL from examples * Remove unused OPC-headers * Make NMR_COM_NATIVE settable on the command line
3dJan
added a commit
that referenced
this pull request
Apr 27, 2023
…code (#83) * First working UTF8-implementation * Remove unused code im xml-reader * Remove plenty of unused 'GCC'-code * Port VS unittests to gtest * Make UTF8-changes and UnitTests compile on linux * Fix MAC build * Address some TODOs * Remove broken COM-functionality * Change some more interfaces to UTF8 * Remove unsused includes and NMR_COM_NATIVE flags * Up the version number * Remove ATL from examples * Remove unused OPC-headers * Make NMR_COM_NATIVE settable on the command line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
It especially simplifies the XML-reader which does not need to convert all input streams from UTF8 to UTF16