Skip to content

Conversation

@jowodo
Copy link
Contributor

@jowodo jowodo commented Nov 9, 2023

  1. I added a hashbang at the beginning of the bash script.
  2. I changed the script in such a way that users are not forced into the name model_angelo for the conda environment. model_angelo is still the default, though. The reason behind this change it that we name the conda environment with the version of the software, so we can install multiple versions of the same software (e.g. modelangelo-1.0.9).

Copy link
Collaborator

@jamaliki jamaliki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamaliki
Copy link
Collaborator

Hi, thank you for your PR! I like this change.

@jamaliki jamaliki merged commit 67dc3d9 into 3dem:main Nov 13, 2023
@jowodo jowodo mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants