This repository was archived by the owner on Nov 24, 2021. It is now read-only.
Bugfix: Pinch to zoom makes images black#49
Merged
3lvis merged 2 commits into3lvis:masterfrom Jul 31, 2016
Merged
Conversation
Owner
|
Thanks @askeland! 👏 👏 👏 👏 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinch to zoom images smaller than the screen size makes the image disappear. This happens because calculating maxZoomScale is failing. The initial widthFactor and heightFactor should be 1.0 instead of 0.0 to prevent getting scaleFactor of 0.0.
Also when updating the image, the maxZoomScale must be recalculated. (when loading large image instead of placeholder). I added an update to this in the didFocus() that worked, but maybe you know a better place :)