fix(term): handle terminal size query failure gracefully#339
Closed
rvyhvn wants to merge 1 commit into3rd:masterfrom
Closed
fix(term): handle terminal size query failure gracefully#339rvyhvn wants to merge 1 commit into3rd:masterfrom
rvyhvn wants to merge 1 commit into3rd:masterfrom
Conversation
Replaces the assertion on ioctl failure with a silent return. This prevents crashes in environments where the terminal size cannot be queried, such as stated here 3rd#210 (comment)). Making it fail silently so the plugin doesn't break the entire editor setup.
3rd
added a commit
that referenced
this pull request
Feb 14, 2026
Changes: - replace assert on ioctl failure with graceful return and user notification in term.lua - guard against nil TIOCGWINSZ on unsupported OS before calling ioctl - initialize cached_size as nil instead of all-zero struct to avoid silent division-by-zero - add nil guards for get_size() in renderer.lua, kitty/init.lua, and document.lua Refs: #210, #339
Owner
|
Thank you, added with some changes in 2f80ec1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the assertion on ioctl failure with a silent return. This prevents crashes in environments where the terminal size cannot be queried, such as stated here #210 (comment).
Making it fail silently so the plugin doesn't break the entire editor setup.