Release version in setup.py commandline should not break setup.py #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@dlaso99 try this please, review it (provide approve eventually), let it get merged and officially released |
As implemented intially it made impossible/hard to install library directly from codebase. Here is an attempt to make it possible again.
dlaso99
approved these changes
Nov 8, 2021
Contributor
dlaso99
left a comment
dlaso99
left a comment
There was a problem hiding this comment.
LGTM & Works on my machine! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As implemented intially it made impossible/hard to install library
directly from codebase. Here is an attempt to make it possible again.