Create pull-secret if provided#28
Merged
ficap merged 1 commit into3scale-qe:mainfrom Nov 10, 2022
mganisin:pull-secret
Merged
Conversation
averevki
suggested changes
Oct 24, 2022
Let the run.sh create the tools namespace and necessary pull-secret if content for pull-secret is provided. The content is docker config referenced via DOCKERCONFIGJSON env variable. DOCKERCONFIGJSON is intentionally different from DOCKER_CONFIG used to provide alternate config location and the name is inspired by name of relevant openshift object.
averevki
approved these changes
Nov 6, 2022
ficap
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the run.sh create the tools namespace and necessary pull-secret if
content for pull-secret is provided. The content is docker config
referenced via DOCKERCONFIGJSON env variable.
DOCKERCONFIGJSON is intentionally different from DOCKER_CONFIG used to
provide alternate config location and the name is inspired by name of
relevant openshift object.