Limit Mockserver memory usage#32
Merged
mganisin merged 1 commit into3scale-qe:mainfrom Jun 19, 2023
Merged
Conversation
mdujava
approved these changes
Jun 13, 2023
|
@pehala are you sure? I know you are :-) anyway brief reasoning why or if this will avoid out of memory tracebacks would be nice. |
Contributor
Author
|
I think it works because the JVM tries to allocate a maximum percentage of available memory. |
Could I ask you to put this assumtion to commit message? |
- It seems to respect the memory limit and the increased usage we saw was just a consequence of having no limit at all
Contributor
Author
Done |
mganisin
approved these changes
Jun 19, 2023
mdujava
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time it actually works (at least so far)