Conversation
davidor
approved these changes
Apr 10, 2018
unleashed
reviewed
Apr 10, 2018
| end | ||
|
|
||
| def test_invalid_percent_encoding | ||
| #We pass a string and not a hash as a parameter due to |
Contributor
There was a problem hiding this comment.
minor nit: leave a space between the comment symbol and the start of the comment for readability
unleashed
approved these changes
Apr 10, 2018
When performing a request with an invalid percentage-encoding format we now return an XML from a Backend::Error type of error. Previously when an invalid percentage-encoding was detected the response was a sinatra error.
miguelsorianod
force-pushed
the
bugfix/invalid-pct-encoding-response-format
branch
from
423f025 to
cb485c7
Compare
Contributor
|
bors r=@unleashed,@davidor |
bors Bot
added a commit
that referenced
this pull request
Apr 10, 2018
14: exception_catcher: return XML response body when invalid %encoding is detected r=unleashed,davidor a=miguelsorianod When performing a request with an invalid percentage-encoding format we now return an XML from a Backend::Error type of error. Previously when an invalid percentage-encoding was detected the response was a sinatra error. This has been done in the same way that was done with the response error management of INVALID_BYTE_SEQUENCE_ERR_MSG Co-authored-by: Miguel Soriano <msoriano@redhat.com>
eguzki
approved these changes
Apr 10, 2018
Member
eguzki
left a comment
eguzki
left a comment
There was a problem hiding this comment.
do not include logic and tests code updates in the same commit. Cleaner in separate commits.
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing a request with an invalid percentage-encoding
format we now return an XML from a Backend::Error type of error.
Previously when an invalid percentage-encoding was detected
the response was a sinatra error.
This has been done in the same way that was done with the response error management of INVALID_BYTE_SEQUENCE_ERR_MSG