Add option to deploy listeners using Falcon#150
Merged
Conversation
| gem 'prometheus-client' | ||
| gem 'yabeda-prometheus', '= 0.1.4' | ||
| gem 'async-redis', '~> 0.4.1' | ||
| gem 'falcon', '~> 0.34' |
Contributor
There was a problem hiding this comment.
License of Falcon as a new dependency is OK?
Passes our license_checker?
unleashed
reviewed
Jan 23, 2020
Contributor
unleashed
left a comment
unleashed
left a comment
There was a problem hiding this comment.
Take a look at the stop comment. I'd say having that will be required to use this more than just an experiment. Otherwise, for just experimenting, it looks ok.
davidor
force-pushed
the
falcon-web-server
branch
from
b340c12 to
1dd6d14
Compare
unleashed
approved these changes
Jan 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to deploy listeners using the Falcon web server as an alternative to Puma. Falcon is a web-server built on top the async lib so we can use it when the listeners are configured to use the async Redis lib instead of the blocking one.
This is still experimental. It works, but needs more testing. Also, there's some functionality provided by Puma that's not in Falcon, you can see that in
lib/3scale/backend/server/falcon.rb. The good news is that this allows us to configure auto-scaling. I've added a guide to configure that in Openshift (#149 ).