Merged
Conversation
unleashed
approved these changes
Feb 3, 2020
Comment on lines
+11
to
+12
| def run_rake_task_in_thread(name, freq, check_once = false) | ||
| Thread.new do |
Contributor
There was a problem hiding this comment.
There is nothing shared between the threads. Have you considered doing a fork + exec? It would avoid the pitfalls of GIL, although this seems like not much of an opportunity to block.
Contributor
Author
There was a problem hiding this comment.
Yes, there's not much blocking. Delete stats has sleeps between SCAN calls and the rescheduling only runs a few redis commands every 5 min by default.
davidor
force-pushed
the
add-delete-stats-to-cron
branch
from
eefaf29 to
25dcfb6
Compare
Contributor
Author
|
@unleashed I force-pushed a minor change to keep the task under the |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the title says.