Allow to configure the referrers validator with the old behavior#190
Merged
Allow to configure the referrers validator with the old behavior#190
Conversation
unleashed
reviewed
Apr 15, 2020
Contributor
unleashed
left a comment
unleashed
left a comment
There was a problem hiding this comment.
Consider the changes in the comments and ping me again.
davidor
force-pushed
the
referrer-filter-legacy
branch
from
86ec6b1 to
1c5287e
Compare
unleashed
approved these changes
Apr 16, 2020
Contributor
unleashed
left a comment
unleashed
left a comment
There was a problem hiding this comment.
👍. The only consideration is that you could leave the common code in the matches? method (escaping and replacing, which you could also do in place with gsub!) and just change the regex in the pattern_matches? method.
davidor
force-pushed
the
referrer-filter-legacy
branch
from
1c5287e to
569a989
Compare
davidor
force-pushed
the
referrer-filter-legacy
branch
from
569a989 to
cd10873
Compare
Contributor
Author
|
I changed that to avoid duplication 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration option to select the referrers validator behavior.
This is needed because there are some users that depend on the old behavior and forcing them to use the new one would break their work flow.