usage_limit: remove seconds from periods set#21
Merged
Conversation
unleashed
reviewed
Apr 23, 2018
| include Storable | ||
|
|
||
| PERIODS = Period::ALL_DESC | ||
| PERIODS = Period::ALL_DESC.reject { |period| period == :second } |
Contributor
There was a problem hiding this comment.
Another option:
Period::ALL_DESC - [:second]
Member
Author
There was a problem hiding this comment.
This
Period::ALL_DESC - [:second]
does not work. It is an array of granularity class objects created here
But somehow (not investigated yet why)
Period::ALL_DESC.reject { |period| period == :second }
works
Contributor
There was a problem hiding this comment.
Because the equality is overridden - set operations are probably looking for an implementation of hash which differs between different objects, so they are not seen as equal. Using Period::Second or Period.from :second would likely work.
Contributor
|
I think we should add tests for this. |
Merged
Contributor
|
@eguzki at minimum we need the constant frozen to merge this |
eguzki
force-pushed
the
remove-seconds-from-periods-set
branch
3 times, most recently
from
dd3a757 to
2c6e8b0
Compare
Member
Author
|
unittests added |
eguzki
force-pushed
the
remove-seconds-from-periods-set
branch
from
2c6e8b0 to
7f1bb5f
Compare
davidor
approved these changes
Apr 27, 2018
Contributor
|
bors r=@unleashed,@davidor |
Contributor
|
@davidor perhaps the edit was not caught by bors? bors r=@unleashed,@davidor |
Contributor
Build failed |
Contributor
|
heisentest again :/ bors r=@unleashed,@davidor |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"seconds" level of granularity does not exist for usage limits. It was tried to load and never found.