Fix default notification batch when left unset#22
Merged
Conversation
eguzki
approved these changes
Apr 24, 2018
Member
|
good job ;) |
Contributor
Author
|
@eguzki thanks :) bors r=@unleashed,@eguzki |
bors Bot
added a commit
that referenced
this pull request
Apr 24, 2018
22: Fix default notification batch when left unset r=unleashed,eguzki a=unleashed The `notification_batch` setting would be set to 0 when unset in the configuration, which would force lots of `NotifyJob`s to be created. Make it default to a reasonable value when not specified. Co-authored-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
notification_batchsetting would be set to 0 when unset in the configuration, which would force lots ofNotifyJobs to be created. Make it default to a reasonable value when not specified.