Skip to content

Remove native oauth feature#226

Merged
unleashed merged 12 commits intomasterfrom
delete-oauth-tokens
Jun 18, 2020
Merged

Remove native oauth feature#226
unleashed merged 12 commits intomasterfrom
delete-oauth-tokens

Conversation

@davidor
Copy link
Copy Markdown
Contributor

@davidor davidor commented Jun 18, 2020

This is a feature that has been deprecated for a long time.
@andreumasferrer gave us the 👍 to delete this.

@davidor davidor requested a review from unleashed June 18, 2020 14:02
Copy link
Copy Markdown
Contributor

@unleashed unleashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The helpers in the listener code and the required params missing error might have been only used by the code removed, but they aren't specific to OAuth tokens and look generic enough that they could be used elsewhere. Maybe there's an opportunity to start using them?

@davidor
Copy link
Copy Markdown
Contributor Author

davidor commented Jun 18, 2020

I don't see how those methods can be reused.

require_params! can't be reused because it raises a generic error whereas the rest of methods in the Listener class raise specific errors such as ServiceIdMissing.
ensure_authenticated! is not needed in the rest of the methods of the class.

@unleashed unleashed merged commit ed69431 into master Jun 18, 2020
@bors bors Bot deleted the delete-oauth-tokens branch June 18, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants