Conversation
unleashed
reviewed
Jun 18, 2020
Contributor
unleashed
left a comment
There was a problem hiding this comment.
The helpers in the listener code and the required params missing error might have been only used by the code removed, but they aren't specific to OAuth tokens and look generic enough that they could be used elsewhere. Maybe there's an opportunity to start using them?
Contributor
Author
|
I don't see how those methods can be reused.
|
unleashed
approved these changes
Jun 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a feature that has been deprecated for a long time.
@andreumasferrer gave us the 👍 to delete this.