Fix Prometheus counter of 5xx errors#230
Merged
Conversation
unleashed
reviewed
Jul 13, 2020
Contributor
unleashed
left a comment
unleashed
left a comment
There was a problem hiding this comment.
If we deploy something that causes an Exception rather than a StandardError, we'll get a 500 but won't report this, and this happens in some special cases such as when having syntax errors, failing to load a file, getting signalled, etc. From a quick search I got a list of non-standarderror exceptions we could see: https://www.honeybadger.io/blog/ruby-exception-vs-standarderror-whats-the-difference/
davidor
force-pushed
the
fix-prometheus-5xx-counter
branch
from
ecbba26 to
565a89e
Compare
unleashed
approved these changes
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://issues.redhat.com/browse/THREESCALE-5622