Use case insensitive strings when parsing booleans in config#245
Merged
Use case insensitive strings when parsing booleans in config#245
Conversation
…ing bools It seems reasonable to expect that something like "True" should work the same as "true". For example, the kubernetes libs used by the saas-operator sets booleans to "True" and "False".
unleashed
reviewed
Jan 18, 2021
Co-authored-by: Alejandro Martinez Ruiz <alex@flawedcode.org>
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems reasonable to expect that something like "True" should work the same as "true".
For example, the kubernetes libs used by our saas-operator sets booleans to "True" and "False".