Conversation
unleashed
approved these changes
Feb 15, 2021
Contributor
unleashed
left a comment
unleashed
left a comment
There was a problem hiding this comment.
LGTM, but check the comment before merging.
| " for ruby_version in \$(rbenv whence ruby); do\n" \ | ||
| " echo \"Switching to \${ruby_version}\"\n" \ | ||
| " rbenv shell \"\${ruby_version}\"\n" \ | ||
| " gem update --system\n" \ |
Contributor
There was a problem hiding this comment.
Have you needed this line for it to work? I remember having had issues with some broken gem updates in the past, so I went with the gem version shipping which each ruby version.
Contributor
Author
There was a problem hiding this comment.
Yes, this is needed for ruby 2.7. With the version installed by default, it crashes.
Contributor
Author
|
bors r=@unleashed |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR install ruby 2.7 in the CI image. It also uninstalls 2.6 because we no longer need to ensure that apisonator works with that version.