Skip to content

Update pry to 0.14.0 and pry-doc to 1.1.0#267

Merged
bors[bot] merged 1 commit intomasterfrom
update-pry-to-0.14
Feb 16, 2021
Merged

Update pry to 0.14.0 and pry-doc to 1.1.0#267
bors[bot] merged 1 commit intomasterfrom
update-pry-to-0.14

Conversation

@davidor
Copy link
Copy Markdown
Contributor

@davidor davidor commented Feb 16, 2021

The pry-doc version that was being used gives a warning on Ruby 2.7. I've updated both pry and pry-doc to the latest version.

[ruby@apisonator-dev apisonator]$ bundle exec pry
ruby/2.7.2 isn't supported by this pry-doc version

@davidor davidor requested a review from unleashed February 16, 2021 09:44
Comment thread Gemfile.base
gem 'pry', '~> 0.11.3'
gem 'pry-doc', '~> 0.11.1'
gem 'pry', '~> 0.14'
gem 'pry-doc', '~> 1.1'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~> 1 should be enough here if pry-doc follows semver (that is not the case with 0.x versions).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.0.0 doesn't support 2.7, so the minimum is 1.1.

@davidor
Copy link
Copy Markdown
Contributor Author

davidor commented Feb 16, 2021

bors r=@unleashed

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Feb 16, 2021

Build succeeded:

@bors bors Bot merged commit 04302ed into master Feb 16, 2021
@bors bors Bot deleted the update-pry-to-0.14 branch February 16, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants