Fix bug that causes Apisonator to stop pinging System to fetch events#292
Merged
Fix bug that causes Apisonator to stop pinging System to fetch events#292
Conversation
davidor
commented
Jun 21, 2021
The previous code fails if the incr call is made effective in Redis but the client returns an error because of a timeout. When that happens, which should be pretty rare, apisonator stops sending events because from that moment, `ping_key_value.to_i == 1` will always be false.
Setting a TTL was working before because it's a valid value for the "expire" Redis command. We need to change this, because when using "SET" with a TTL, it raises.
davidor
force-pushed
the
fix-events-pending-ping
branch
from
66e6a26 to
36f1d35
Compare
Contributor
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code fails if the incr call is made effective in Redis but the client returns an error because of a timeout. When that happens, which should be pretty rare, apisonator stops sending events because from that moment,
ping_key_value.to_i == 1inapisonator/lib/3scale/backend/event_storage.rb
Line 99 in 677dfbf