Skip to content

Async storage: read all responses in pipelines even if some of them are errors#302

Merged
bors[bot] merged 1 commit intomasterfrom
fix-pipelines-error-async-mode
Jul 12, 2021
Merged

Async storage: read all responses in pipelines even if some of them are errors#302
bors[bot] merged 1 commit intomasterfrom
fix-pipelines-error-async-mode

Conversation

@davidor
Copy link
Copy Markdown
Contributor

@davidor davidor commented Jul 12, 2021

Redis returns an answer for each of the commands sent in the pipeline, but we were not reading all of them. We stopped at the first error. This PR fixes the issue.

@davidor davidor requested a review from unleashed July 12, 2021 17:32
@davidor davidor force-pushed the fix-pipelines-error-async-mode branch from 750a5ed to 730442e Compare July 12, 2021 17:51
Copy link
Copy Markdown
Contributor

@unleashed unleashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Jul 12, 2021

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Jul 12, 2021

Build succeeded:

@bors bors Bot merged commit 1754cc0 into master Jul 12, 2021
@bors bors Bot deleted the fix-pipelines-error-async-mode branch July 12, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants