Conversation
There was a race condition in a spec trying to test another race
condition. :)
Issues fixed:
- "wakeup" on a thread needs it to be alive.
- "sleep" status can also mean I/O blocked, not just stopped.
- Thread.stop was being called to sync at the end, which is
useless. It is now used to give a better chance at parallelism
by sync'ing before starting the real workload of each thread.
- The Rspec stubbing is unnecessary.
davidor
approved these changes
Jun 11, 2018
eguzki
approved these changes
Jun 11, 2018
Contributor
Author
bors Bot
added a commit
that referenced
this pull request
Jun 11, 2018
32: Fix race condition in running the race condition test in EventStorage r=davidor,eguzki a=unleashed There was a race condition in a spec trying to test a race condition. So meta. :) Closes #31. Hopefully deals the fatal blow to the failing builds, which has been nagging us for too long. Issues fixed: - "wakeup" on a thread needs it to be alive. - "sleep" status can also mean I/O blocked, not just stopped. - Thread.stop was being called to sync at the end, which is useless. It is now used to give a better chance at parallelism by sync'ing before starting the real workload of each thread. - The Rspec stubbing is unnecessary. Co-authored-by: Alejandro Martinez Ruiz <alex@flawedcode.org>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a race condition in a spec trying to test a race condition. So meta. :)
Closes #31. Hopefully deals the fatal blow to the failing builds, which has been nagging us for too long.
Issues fixed:
useless. It is now used to give a better chance at parallelism
by sync'ing before starting the real workload of each thread.